Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation problem with ARC in some compilers. #384

Merged
merged 1 commit into from Mar 27, 2019
Merged

Fix compilation problem with ARC in some compilers. #384

merged 1 commit into from Mar 27, 2019

Conversation

ronsaldo
Copy link
Contributor

This fixes a compilation error that is produced by some versions of clang. No ARC pointers in structs are allowed.

eliotmiranda
eliotmiranda approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@eliotmiranda eliotmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, but only with the 10.12 SDK (i.e. -metal doesn't crash on startup; still doesn't render correctly).
So for now we're targeting the 10.12 SDK.

@eliotmiranda eliotmiranda merged commit 191f901 into OpenSmalltalk:Cog Mar 27, 2019
@ronsaldo ronsaldo deleted the feature/metal_b3d branch May 11, 2019 01:05
hogoww referenced this pull request in hogoww/opensmalltalk-vm Dec 23, 2021
@hogoww
Mutant pharo-project#384, Installing [ Replace #and: with #or: ] on m…
20d2854 
…ethod [ markAndTraceClassOf: ]
hogoww referenced this pull request in hogoww/opensmalltalk-vm Dec 23, 2021
@hogoww
Mutant pharo-project#384, Reverting [ Replace #and: with #or: ] on me…
896b4c7 
…thod [ markAndTraceClassOf: ] KILLED by 1/10 test cases.
hogoww referenced this pull request in hogoww/opensmalltalk-vm Dec 29, 2021
@hogoww
Mutant pharo-project#384, Installing [ Replace #- with #+ ] on method…
764a27a 
… [ addToFreeTree:bytes: ]
hogoww referenced this pull request in hogoww/opensmalltalk-vm Dec 29, 2021
@hogoww
Mutant pharo-project#384, Reverting [ Replace #- with #+ ] on method …
9c2e613 
…[ addToFreeTree:bytes: ] KILLED by 1/234 test cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliotmiranda eliotmiranda eliotmiranda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ronsaldo @eliotmiranda